Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minmax] Do nothing for empty suffix/prefix. #202

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[minmax] Do nothing for empty suffix/prefix. #202

merged 2 commits into from
Oct 31, 2023

Conversation

ttsugriy
Copy link
Contributor

@ttsugriy ttsugriy commented Sep 8, 2023

Semantically it's a noop but it's slightly more efficient for the case when max/min is requested for an empty Collection.

@ttsugriy
[minmax] Do nothing for empty suffix/prefix.
e5ea054 
It's a semantical noop but slightly more efficient for the case when max/min is requested for an empty Collection.
@stephentyrone
Copy link
Member

@swift-ci test

@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000
Copy link
Member

Thanks for this fix, @ttsugriy! 👏🏻

@natecook1000 natecook1000 merged commit dd4e0e7 into apple:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttsugriy @stephentyrone @natecook1000